tombentley commented on a change in pull request #10206:
URL: https://github.com/apache/kafka/pull/10206#discussion_r584641483
##########
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala
##########
@@ -223,6 +224,46 @@ class TransactionStateManager(brokerId: Int,
throw new IllegalStateException(s"Unexpected empty transaction metadata
returned while putting $txnMetadata")))
}
+ def listTransactionStates(
+ filterProducerIds: Set[Long],
+ filterStateNames: Set[String]
+ ): Either[Errors, List[ListTransactionsResponseData.TransactionState]] = {
+ inReadLock(stateLock) {
+ if (loadingPartitions.nonEmpty) {
+ Left(Errors.COORDINATOR_LOAD_IN_PROGRESS)
+ } else {
+ val filterStates = filterStateNames.flatMap(TransactionState.fromName)
Review comment:
How are the states going to be documented (e.g. in the Admin client?) It
seems odd to me that on the one hand "they're an impl detail", but they're also
used in the filter. How could someone write code to list all of the transaction
not in a given state if they can't know the universe of states (given new
states could be added in the future)?
##########
File path:
clients/src/main/resources/common/message/ListTransactionsResponse.json
##########
@@ -0,0 +1,32 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ "apiKey": 66,
+ "type": "response",
+ "name": "ListTransactionsResponse",
+ "validVersions": "0",
+ "flexibleVersions": "0+",
+ "fields": [
+ { "name": "ThrottleTimeMs", "type": "int32", "versions": "0+",
+ "about": "The duration in milliseconds for which the request was
throttled due to a quota violation, or zero if the request did not violate any
quota." },
+ { "name": "ErrorCode", "type": "int16", "versions": "0+" },
+ { "name": "TransactionStates", "type": "[]TransactionState", "versions":
"0+", "fields": [
+ { "name": "TransactionalId", "type": "string", "versions": "0+",
"entityType": "transactionalId" },
+ { "name": "ProducerId", "type": "int64", "versions": "0+",
"entityType": "producerId" },
+ { "name": "TransactionState", "type": "string", "versions": "0+" }
Review comment:
Shouldn't these also have `about` properties?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
