hachikuji commented on a change in pull request #10206:
URL: https://github.com/apache/kafka/pull/10206#discussion_r585622686
##########
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala
##########
@@ -223,6 +224,63 @@ class TransactionStateManager(brokerId: Int,
throw new IllegalStateException(s"Unexpected empty transaction metadata
returned while putting $txnMetadata")))
}
+ def listTransactionStates(
+ filterProducerIds: Set[Long],
+ filterStateNames: Set[String]
+ ): ListTransactionsResponseData = {
+ inReadLock(stateLock) {
+ val response = new ListTransactionsResponseData()
+ if (loadingPartitions.nonEmpty) {
+ response.setErrorCode(Errors.COORDINATOR_LOAD_IN_PROGRESS.code)
+ } else {
+ val filterStates = mutable.Set.empty[TransactionState]
+ val unknownStates = new java.util.ArrayList[String]
+ filterStateNames.foreach { stateName =>
+ TransactionState.fromName(stateName) match {
+ case Some(state) => filterStates += state
+ case None => unknownStates.add(stateName)
Review comment:
Yeah, I agree. It is simpler. I guess I don't have a strong reason to
make this field nullable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
