chia7712 commented on a change in pull request #10206:
URL: https://github.com/apache/kafka/pull/10206#discussion_r585656746
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -3303,6 +3304,28 @@ class KafkaApis(val requestChannel: RequestChannel,
new
DescribeTransactionsResponse(response.setThrottleTimeMs(requestThrottleMs)))
}
+ def handleListTransactionsRequest(request: RequestChannel.Request): Unit = {
+ val listTransactionsRequest = request.body[ListTransactionsRequest]
+ val filteredProducerIds =
listTransactionsRequest.data.producerIdFilter.asScala.map(Long.unbox).toSet
+ val filteredStates =
listTransactionsRequest.data.statesFilter.asScala.toSet
+ val response = txnCoordinator.handleListTransactions(filteredProducerIds,
filteredStates)
+
+ // The response should contain only transactionalIds that the principal
+ // has `Describe` permission to access.
+ if (response.transactionStates != null) {
+ val transactionStateIter = response.transactionStates.iterator()
+ while (transactionStateIter.hasNext) {
Review comment:
Thanks for this nice explanation :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
