[GitHub] [kafka] cmccabe commented on a change in pull request #10254: KAFKA-12406 Integrate client quotas with raft broker

[GitBox]

cmccabe commented on a change in pull request #10254:
URL: https://github.com/apache/kafka/pull/10254#discussion_r607263189



##########
File path: core/src/main/scala/kafka/server/metadata/ClientQuotaCache.scala
##########
@@ -122,6 +122,14 @@ class ClientQuotaCache {
       entityFilters.put(entityType, entityMatch)
     }
 
+    // Special case for non-strict empty filter, match everything

Review comment:
       What happens if we have an empty filter list and strict mode set?  It 
looks like an exception is thrown-- that doesn't seem correct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org