cmccabe commented on a change in pull request #10254:
URL: https://github.com/apache/kafka/pull/10254#discussion_r607270847
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/ClientQuotaControlManager.java
##########
@@ -170,8 +170,10 @@ private void alterClientQuotaEntity(
}
});
- outputRecords.addAll(newRecords);
- outputResults.put(entity, ApiError.NONE);
+ // Only add the records to outputRecords if there were no errors
Review comment:
This is a good fix.
However, I think it would be better just to return immediately after setting
the error, rather than waiting until the end of the function. That's
consistent with how we handle errors at the top of this function, and in other
manager classes. It makes it clear that only one error can be set for each
entity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
