[GitHub] [kafka] cmccabe commented on a change in pull request #10254: KAFKA-12406 Integrate client quotas with raft broker

[GitBox]

cmccabe commented on a change in pull request #10254:
URL: https://github.com/apache/kafka/pull/10254#discussion_r607263869



##########
File path: 
core/src/main/scala/kafka/server/metadata/ClientQuotaMetadataManager.scala
##########
@@ -121,16 +121,16 @@ class ClientQuotaMetadataManager(private[metadata] val 
quotaManagers: QuotaManag
       return
     }
 
-    // Update the cache
-    quotaCache.updateQuotaCache(ipEntity, quotaRecord.key, quotaRecord.value, 
quotaRecord.remove)
-
     // Convert the value to an appropriate Option for the quota manager
     val newValue = if (quotaRecord.remove()) {
       None
     } else {
       Some(quotaRecord.value).map(_.toInt)
     }
     connectionQuotas.updateIpConnectionRateQuota(inetAddress, newValue)
+
+    // Update the cache

Review comment:
       What's the purpose of moving this code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org