ijuma commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608214927
##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -614,18 +613,3 @@ class NoOpMessageFormatter extends MessageFormatter {
def writeTo(consumerRecord: ConsumerRecord[Array[Byte], Array[Byte]],
output: PrintStream): Unit = {}
}
-class ChecksumMessageFormatter extends MessageFormatter {
Review comment:
Good question, I was debating it myself. Technically, this is not public
API since it's not mentioned in the public javadoc and it's in the `core`
module (everything is private in the `core` module).
However, it is possible that people would pass this class when using the
console consumer. The checksum value has never been correct for message format
2, which has been the default since 0.11, so I figured the chances that people
actually used this semi public API is low. Seems like there isn't much harm in
mentioning it in the upgrade notes though, so will add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
