ijuma commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608342700
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/RecordMetadata.java
##########
@@ -42,20 +41,26 @@
private final int serializedValueSize;
private final TopicPartition topicPartition;
- private volatile Long checksum;
-
public RecordMetadata(TopicPartition topicPartition, long baseOffset, long
relativeOffset, long timestamp,
- Long checksum, int serializedKeySize, int
serializedValueSize) {
+ int serializedKeySize, int serializedValueSize) {
// ignore the relativeOffset if the base offset is -1,
// since this indicates the offset is unknown
this.offset = baseOffset == -1 ? baseOffset : baseOffset +
relativeOffset;
this.timestamp = timestamp;
- this.checksum = checksum;
this.serializedKeySize = serializedKeySize;
this.serializedValueSize = serializedValueSize;
this.topicPartition = topicPartition;
}
+ /**
+ * @deprecated use constructor without `checksum` parameter.
+ */
+ @Deprecated
+ public RecordMetadata(TopicPartition topicPartition, long baseOffset, long
relativeOffset, long timestamp,
Review comment:
I probably need to add back some of the `ConsumerRecord` constructors
since they were not previously deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
