ijuma commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608347559
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##########
@@ -1385,7 +1385,7 @@ private void handleOffsetOutOfRange(FetchPosition
fetchPosition, TopicPartition
byte[] valueByteArray = valueBytes == null ? null :
Utils.toArray(valueBytes);
V value = valueBytes == null ? null :
this.valueDeserializer.deserialize(partition.topic(), headers, valueByteArray);
return new ConsumerRecord<>(partition.topic(),
partition.partition(), offset,
- timestamp, timestampType,
record.checksumOrNull(),
Review comment:
I don't think that suggestion works. However, you could add conditional
code in `DumpLogSegments` so that the crc at the record level is only printed
if it's `AbstractLegacyRecordBatch`. Sounds good as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
