mjsax commented on a change in pull request #10482:
URL: https://github.com/apache/kafka/pull/10482#discussion_r609907071



##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -1031,6 +1032,23 @@ protected StreamsConfig(final Map<?, ?> props,
         if (props.containsKey(RETRIES_CONFIG)) {
             log.warn("Configuration parameter `{}` is deprecated and will be 
removed in 3.0.0 release.", RETRIES_CONFIG);
         }
+
+        if (eosEnabled) {
+            verifyEOSTransactionTimeoutCompatibility();
+        }
+    }
+
+    private void verifyEOSTransactionTimeoutCompatibility() {
+        final int commitInterval = ((Long) 
(originals().getOrDefault(COMMIT_INTERVAL_MS_CONFIG, 
EOS_DEFAULT_COMMIT_INTERVAL_MS))).intValue();

Review comment:
       We should use `long` as `commitInterval` is declared a LONG in 
`StreamsConfig`:
   ```
   .define(COMMIT_INTERVAL_MS_CONFIG,
                       Type.LONG,
                       DEFAULT_COMMIT_INTERVAL_MS,
                       atLeast(0),
                       Importance.LOW,
                       COMMIT_INTERVAL_MS_DOC)
   ```

##########
File path: 
streams/examples/src/main/java/org/apache/kafka/streams/examples/pageview/PageViewTypedDemo.java
##########
@@ -181,7 +181,7 @@ public static void main(final String[] args) {
         props.put(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, 
JSONSerde.class);
         props.put(StreamsConfig.DEFAULT_WINDOWED_VALUE_SERDE_INNER_CLASS, 
JSONSerde.class);
         props.put(StreamsConfig.CACHE_MAX_BYTES_BUFFERING_CONFIG, 0);
-        props.put(StreamsConfig.COMMIT_INTERVAL_MS_CONFIG, 1000);
+        props.put(StreamsConfig.COMMIT_INTERVAL_MS_CONFIG, 1000L);

Review comment:
       Why do we update all this? While not incorrect, should not be necessary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to