abbccdda commented on a change in pull request #10482:
URL: https://github.com/apache/kafka/pull/10482#discussion_r609920651
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -1031,6 +1032,23 @@ protected StreamsConfig(final Map<?, ?> props,
if (props.containsKey(RETRIES_CONFIG)) {
log.warn("Configuration parameter `{}` is deprecated and will be
removed in 3.0.0 release.", RETRIES_CONFIG);
}
+
+ if (eosEnabled) {
+ verifyEOSTransactionTimeoutCompatibility();
+ }
+ }
+
+ private void verifyEOSTransactionTimeoutCompatibility() {
+ final int commitInterval = ((Long)
(originals().getOrDefault(COMMIT_INTERVAL_MS_CONFIG,
EOS_DEFAULT_COMMIT_INTERVAL_MS))).intValue();
Review comment:
We need to either convert transaction timeout or commit interval I
assume. Will switch to long comparison instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
