ableegoldman commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r619558551
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -603,7 +606,7 @@ boolean runLoop() {
log.error("Shutting down because the Kafka cluster seems
to be on a too old version. " +
"Setting {}=\"{}\" requires broker version 2.5
or higher.",
StreamsConfig.PROCESSING_GUARANTEE_CONFIG,
- EXACTLY_ONCE_BETA);
+ StreamsConfig.EXACTLY_ONCE_V2);
Review comment:
My rationale was that if a user is hitting this then it's presumably a
new application that they just tried to enable eos-v2 with, without upgrading
their brokers. And if it's a new 3.0 application then why would they have
chosen the deprecated eos-beta config over the eos-v2 config.
But I can try to print the actual result, it just requires a little extra
code to look this up and save it since we don't track the configs after the
thread's creation. Not the end of the world, but didn't feel necessary to me.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
