[GitHub] [kafka] mjsax commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

[GitBox]

mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r619876217



##########
File path: docs/streams/upgrade-guide.html
##########
@@ -93,6 +95,12 @@ <h1>Upgrade Guide and API Changes</h1>
     </p>
 
     <h3><a id="streams_api_changes_300" 
href="#streams_api_changes_300">Streams API changes in 3.0.0</a></h3>
+    <p>
+      The <code>StreamsConfig.EXACTLY_ONCE</code> and 
<code>StreamsConfig.EXACTLY_ONCE_BETA</code> configs have been deprecated, and 
a new <code>StreamsConfig.EXACTLY_ONCE_V2</code> config has been

Review comment:
       Well, we do deprecate `StreamsConfig.EXACTLY_ONCE`, too, but user might 
just do `config.put("processing.guarantee", "exactly_once");` (or have a config 
file with `"exactly_once"`) in it. To me, the main change is that the config 
itself is deprecated and the deprecation of variable is just a "side effect".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org