mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r619875764



##########
File path: docs/streams/upgrade-guide.html
##########
@@ -93,6 +95,12 @@ <h1>Upgrade Guide and API Changes</h1>
     </p>
 
     <h3><a id="streams_api_changes_300" 
href="#streams_api_changes_300">Streams API changes in 3.0.0</a></h3>
+    <p>
+      The <code>StreamsConfig.EXACTLY_ONCE</code> and 
<code>StreamsConfig.EXACTLY_ONCE_BETA</code> configs have been deprecated, and 
a new <code>StreamsConfig.EXACTLY_ONCE_V2</code> config has been
+      introduced. This is the same feature as eos-beta, but renamed to 
highlight its production-readiness. Users of exactly-once semantics should plan 
to migrate to the eos-v2 config and prepare for the removal of the deprecated 
configs in 4.0 or after at least a year

Review comment:
       I would be very bolt about it:
   ```
   We deprecated <code>processing.guarantee</code> configuration value 
<code>"exactly_once"</code>
   (for EOS version 1) in favor of the improved EOS version 2, formerly 
configured via
   <code>"exactly_once_beta</code>. To avoid the confusion about the term 
"beta" in the config value
   (it was never meant to imply it's not production ready), we furthermore 
renamed
   <code>"exactly_once_beta"</code> to <code>"exactly_once_v2"</code>. 
   ```
   
   Or something similar.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to