cmccabe commented on a change in pull request #10504:
URL: https://github.com/apache/kafka/pull/10504#discussion_r635532912
##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -2376,6 +2375,82 @@ class KafkaController(val config: KafkaConfig,
}
}
+ def allocateProducerIds(allocateProducerIdsRequest:
AllocateProducerIdsRequestData,
+ callback: AllocateProducerIdsResponseData => Unit):
Unit = {
+
+ def eventManagerCallback(results: Either[Errors, ProducerIdsBlock]): Unit
= {
+ results match {
+ case Left(error) => callback.apply(new
AllocateProducerIdsResponseData().setErrorCode(error.code))
+ case Right(pidBlock) => callback.apply(
+ new AllocateProducerIdsResponseData()
+ .setProducerIdStart(pidBlock.producerIdStart())
+ .setProducerIdLen(pidBlock.producerIdLen()))
+ }
+ }
+ eventManager.put(AllocateProducerIds(allocateProducerIdsRequest.brokerId,
+ allocateProducerIdsRequest.brokerEpoch, eventManagerCallback))
+ }
+
+ def processAllocateProducerIds(brokerId: Int, brokerEpoch: Long, callback:
Either[Errors, ProducerIdsBlock] => Unit): Unit = {
+ // Handle a few short-circuits
+ if (!isActive) {
+ callback.apply(Left(Errors.NOT_CONTROLLER))
+ return
+ }
+
+ val brokerEpochOpt = controllerContext.liveBrokerIdAndEpochs.get(brokerId)
+ if (brokerEpochOpt.isEmpty) {
+ warn(s"Ignoring AllocateProducerIds due to unknown broker $brokerId")
+ callback.apply(Left(Errors.STALE_BROKER_EPOCH))
Review comment:
The quorum controller and the zk controller are two implementations of
the same API protocol. It is always fine (in fact, it's necessary) to reuse
error codes for both where appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
