cmccabe commented on a change in pull request #10504:
URL: https://github.com/apache/kafka/pull/10504#discussion_r635572503
##########
File path: core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java
##########
@@ -248,5 +261,17 @@ public void stop() {
clusterReference.get().tearDown();
}
}
+
+ @Override
+ public void rollingBrokerRestart() {
+ if (started.get()) {
+ for (int i = 0; i < clusterReference.get().brokerCount(); i++)
{
+ clusterReference.get().killBroker(i);
+ }
+ clusterReference.get().restartDeadBrokers(true);
+ } else {
Review comment:
It would be a bit nicer to move this section to the front, to get rid of
the nesting here.
##########
File path: core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java
##########
@@ -248,5 +261,17 @@ public void stop() {
clusterReference.get().tearDown();
}
}
+
+ @Override
+ public void rollingBrokerRestart() {
+ if (started.get()) {
+ for (int i = 0; i < clusterReference.get().brokerCount(); i++)
{
+ clusterReference.get().killBroker(i);
+ }
+ clusterReference.get().restartDeadBrokers(true);
+ } else {
Review comment:
It would be a bit nicer to move this section to the beginning, to get
rid of the nesting here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
