xvrl commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r667078995
##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -392,25 +401,25 @@ object ConsoleConsumer extends Logging {
}
}
- private[tools] class ConsumerWrapper(topic: Option[String], partitionId:
Option[Int], offset: Option[Long], whitelist: Option[String],
+ private[tools] class ConsumerWrapper(topic: Option[String], partitionId:
Option[Int], offset: Option[Long], includedList: Option[String],
Review comment:
nit, since it's not really a list, maybe we should use the name
`include` or `includeTopics` instead, similar to what you did here
https://github.com/apache/kafka/commit/51796bcdef2e93ee4176415961ab98dd7407ebec#diff-54be3f408ff6ce6c9fb454bd25a3c67b1dea23b5da663f9d7e17b5b946222324R101
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
