dajac commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r667364123
##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging {
formatter.configure(formatterArgs.asScala.asJava)
- val topicOrFilterOpt = List(topicOpt, whitelistOpt).filter(options.has)
+ val topicOrFilterOpt = List(topicOpt, whitelistOpt,
includeOpt).filter(options.has)
if (topicOrFilterOpt.size != 1)
- CommandLineUtils.printUsageAndDie(parser, "Exactly one of
whitelist/topic is required.")
+ CommandLineUtils.printUsageAndDie(parser, "Exactly one of include/topic
is required.")
Review comment:
I don't know if we did this somewhere else.
I just think that the error message is confusing for folks who would use the
deprecated argument. Say you provide the deprecated one with topic and you get
an error which mention the new one. This is confusing.
As an alternative, we could actually mention the one that was used in the
error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
