xvrl commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r667362757
##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging {
formatter.configure(formatterArgs.asScala.asJava)
- val topicOrFilterOpt = List(topicOpt, whitelistOpt).filter(options.has)
+ val topicOrFilterOpt = List(topicOpt, whitelistOpt,
includeOpt).filter(options.has)
if (topicOrFilterOpt.size != 1)
- CommandLineUtils.printUsageAndDie(parser, "Exactly one of
whitelist/topic is required.")
+ CommandLineUtils.printUsageAndDie(parser, "Exactly one of include/topic
is required.")
Review comment:
I'm not sure if it makes sense to list deprecated configurations in
error messages, do we do this elsewhere? The option would still show up in the
usage help that gets printed following the error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
