[GitHub] [kafka] showuon commented on a change in pull request #11242: [WIP] MINOR: POC for KIP-591

[GitBox]

showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r692948732



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/internals/MaterializedInternal.java
##########
@@ -29,14 +31,26 @@
     private final boolean queryable;
 
     public MaterializedInternal(final Materialized<K, V, S> materialized) {
-        this(materialized, null, null);
+        this(materialized, null, null, null);
     }
 
     public MaterializedInternal(final Materialized<K, V, S> materialized,
                                 final InternalNameProvider nameProvider,
                                 final String generatedStorePrefix) {
+        this(materialized, nameProvider, generatedStorePrefix, null);
+    }
+
+    public MaterializedInternal(final Materialized<K, V, S> materialized,
+                                final InternalNameProvider nameProvider,
+                                final String generatedStorePrefix,
+                                final StreamsConfig config) {
         super(materialized);
 
+        if (config != null && this.storeSupplier == null && 
this.storeImplementation != null) {
+            // get default store implementation
+            this.storeImplementation = config.defaultStoreImplementation();
+        }

Review comment:
       new constructor for `MaterializedInternal`, to accept one more 
paremeter: `StreamConfig`, so that we can store the `storeImplementation` 
setting for later initialization.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org