[GitHub] [kafka] showuon commented on a change in pull request #11242: [WIP] MINOR: POC for KIP-591: Add config to set default store impl class

[GitBox]

showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r696592661



##########
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##########
@@ -1066,12 +1068,22 @@ private Topology getStatefulTopology(final String 
inputTopic,
                                          final String storeName,
                                          final String globalStoreName,
                                          final boolean isPersistentStore) {
+//        final StoreBuilder<KeyValueStore<String, Long>> storeBuilder = 
Stores.keyValueStoreBuilder(
+//            isPersistentStore ?
+//                Stores.persistentKeyValueStore(storeName)
+//                : Stores.inMemoryKeyValueStore(storeName),
+//            Serdes.String(),
+//            Serdes.Long());
+
+        // an example to use store implementation to create the store builder 
for processor API
         final StoreBuilder<KeyValueStore<String, Long>> storeBuilder = 
Stores.keyValueStoreBuilder(
             isPersistentStore ?
-                Stores.persistentKeyValueStore(storeName)
-                : Stores.inMemoryKeyValueStore(storeName),
+                new RocksDBStoreImplementation()
+                : new InMemoryStoreImplementation(),
+            storeName,
             Serdes.String(),
             Serdes.Long());

Review comment:
       An example to use `StoreImplementation` to create the store builder for 
processor API.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org