showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r692950023
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SessionWindowedKStreamImpl.java
##########
@@ -237,10 +238,21 @@
+ " grace=[" +
windows.gracePeriodMs() + "],"
+ " retention=[" +
retentionPeriod + "]");
}
- supplier = Stores.persistentSessionStore(
- materialized.storeName(),
- Duration.ofMillis(retentionPeriod)
- );
+
+ // get from default store implementation
+ StoreImplementation storeImplementation =
materialized.storeImplementation();
+ if (storeImplementation != null) {
+ supplier = storeImplementation.sessionBytesStoreSupplier(
+ materialized.storeName(),
+ Duration.ofMillis(retentionPeriod));
+ } else {
+ // fall back to use Rocks Db by default if no store
implementation provided
Review comment:
Originally, when storeSupplier in materialized is null, we'll use `Rocks
DB`. Now, we'll honor the `storeImplementation` setting (if we got props)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
