C0urante commented on a change in pull request #11382:
URL: https://github.com/apache/kafka/pull/11382#discussion_r753308642
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -366,7 +367,11 @@ private boolean sendRecords() {
if (e != null) {
log.error("{} failed to send record to {}: ",
WorkerSourceTask.this, topic, e);
Review comment:
Should we modify this line to respect the
[errors.log.enable](https://kafka.apache.org/30/documentation.html#sourceconnectorconfigs_errors.log.enable)
(and possibly
[errors.log.include.messages](https://kafka.apache.org/30/documentation.html#sourceconnectorconfigs_errors.log.include.messages))
properties?
I wonder if it might be useful to still unconditionally set
`producerSendException` (or perhaps even convert that field from an
`AtomicReference<Throwable>` to some kind of list, and append to it here) and
then modify the contents (and possibly also name) of
`maybeThrowProducerSendException` to have our error-handling logic. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
