C0urante commented on a change in pull request #11382:
URL: https://github.com/apache/kafka/pull/11382#discussion_r753311712
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -366,7 +367,11 @@ private boolean sendRecords() {
if (e != null) {
log.error("{} failed to send record to {}: ",
WorkerSourceTask.this, topic, e);
Review comment:
Actually, that may complicate things by causing records to be given to
`SourceTask::commitRecord` out of order (a record that caused a producer
failure may be committed after a record that was dispatched to the producer
after it). So probably best to keep the error-handling logic here, but I do
still wonder if we can respect the logging-related configuration properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
