C0urante commented on a change in pull request #11382:
URL: https://github.com/apache/kafka/pull/11382#discussion_r754408473



##########
File path: 
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -366,7 +367,11 @@ private boolean sendRecords() {
                         if (e != null) {
                             log.error("{} failed to send record to {}: ", 
WorkerSourceTask.this, topic, e);

Review comment:
       Yes, I was thinking the behavior could be something like that code 
snippet, although we'd also want to respect the 
[errors.log.include.messages](https://kafka.apache.org/30/documentation.html#sourceconnectorconfigs_errors.log.include.messages)
 property and would probably want the format of the error messages to be 
similar to the error messages we emit in other places where messages are 
tolerated (such as when conversion or transformation fails).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to