ableegoldman commented on pull request #11868:
URL: https://github.com/apache/kafka/pull/11868#issuecomment-1063651734


   Ah good catch @wcarlson5 , I need to move the offset reset logic out of the 
actual `removeNamedTopology` call and make sure we don't block on the offsets 
being removed until the `get()` -- otherwise we get deadlock if we have two 
Streams clients and try to remove a named topology from both from a single 
thread. (To clarify for anyone else, this is not really a realistic/recommended 
usage pattern for real applications, but it helps keep the tests simple and 
makes for a more intuitive blocking behavior anyways)
   
   Anyways I'll push a fix for this, and then we should be good to go 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to