ableegoldman commented on a change in pull request #11868: URL: https://github.com/apache/kafka/pull/11868#discussion_r823417406
########## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ########## @@ -239,12 +238,16 @@ public RemoveNamedTopologyResult removeNamedTopology(final String topologyToRemo final boolean skipResetForUnstartedApplication = maybeCompleteFutureIfStillInCREATED(removeTopologyFuture, "removing topology " + topologyToRemove); - if (resetOffsets && !skipResetForUnstartedApplication) { + if (resetOffsets && !skipResetForUnstartedApplication && !partitionsToReset.isEmpty()) { Review comment: Moved the `!partitionsToReset.isEmpty()` check here to make sure we don't log the line about resetting offsets if we don't actually have any offsets to reset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org