ableegoldman commented on a change in pull request #11868:
URL: https://github.com/apache/kafka/pull/11868#discussion_r823421770
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/RemoveNamedTopologyResult.java
##########
@@ -52,34 +60,54 @@ public RemoveNamedTopologyResult(final KafkaFuture<Void>
removeTopologyFuture) {
* successfully completed their corresponding {@link KafkaFuture}.
*/
public final KafkaFuture<Void> all() {
- final KafkaFutureImpl<Void> result = new KafkaFutureImpl<>();
+ if (resetOffsetsFuture == null) {
+ return removeTopologyFuture;
+ } else {
+ return resetOffsetsFuture;
Review comment:
Basically we now have the caller thread perform the offset reset and
block on it when it goes to call `get()` on the future returned by
`RemoveNamedTopologyResult#all` (or `#resetOffsetsFuture`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
