showuon commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r826683733
########## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ########## @@ -144,10 +148,15 @@ private static final long DEFAULT_COMMIT_INTERVAL_MS = 30000L; private static final long EOS_DEFAULT_COMMIT_INTERVAL_MS = 100L; private static final int DEFAULT_TRANSACTION_TIMEOUT = 10000; + private static final short DEFAULT_MAX_CLIENT_TAG_KEY_VALUE_LENGTH = 40; public static final int DUMMY_THREAD_INDEX = 1; public static final long MAX_TASK_IDLE_MS_DISABLED = -1; + public static final int MAX_RACK_AWARE_ASSIGNMENT_TAG_LIST_SIZE = 10; + public static final int MAX_RACK_AWARE_ASSIGNMENT_TAG_KEY_LENGTH = 50; + public static final int MAX_RACK_AWARE_ASSIGNMENT_TAG_VALUE_LENGTH = 100; Review comment: Make sense to me. Could we add a comment above these line, to mention we have these limitation because these tag value will be encoded into subscription info, sth like that? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org