cadonna commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r826908752
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -144,10 +148,15 @@
private static final long DEFAULT_COMMIT_INTERVAL_MS = 30000L;
private static final long EOS_DEFAULT_COMMIT_INTERVAL_MS = 100L;
private static final int DEFAULT_TRANSACTION_TIMEOUT = 10000;
+ private static final short DEFAULT_MAX_CLIENT_TAG_KEY_VALUE_LENGTH = 40;
public static final int DUMMY_THREAD_INDEX = 1;
public static final long MAX_TASK_IDLE_MS_DISABLED = -1;
+ public static final int MAX_RACK_AWARE_ASSIGNMENT_TAG_LIST_SIZE = 10;
+ public static final int MAX_RACK_AWARE_ASSIGNMENT_TAG_KEY_LENGTH = 50;
+ public static final int MAX_RACK_AWARE_ASSIGNMENT_TAG_VALUE_LENGTH = 100;
Review comment:
I am a bit concerned about the length. I would propose the following:
```
MAX_RACK_AWARE_ASSIGNMENT_TAG_LIST_SIZE = 5
MAX_RACK_AWARE_ASSIGNMENT_TAG_KEY_LENGTH = 20
MAX_RACK_AWARE_ASSIGNMENT_TAG_VALUE_LENGTH = 30
```
We can always increase these numbers in future if they are too small, but if
we want to decrease them, we might run into backwards compatibility issues.
But more important, we should have an integration test that tests the
maximum allowed size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
