showuon commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r826762433
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StandbyTaskAssignmentUtils.java
##########
@@ -49,7 +53,11 @@ static int
pollClientAndMaybeAssignAndUpdateRemainingStandbyTasks(final Map<UUID
tasksToRemainingStandbys.put(activeTaskId, numRemainingStandbys);
}
- return numRemainingStandbys;
+ log.warn("Unable to assign {} of {} standby tasks for task [{}]. " +
Review comment:
This doesn't look right. We log the warning to user even when
`numRemainingStandbys==0`?
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StandbyTaskAssignmentUtils.java
##########
@@ -26,17 +27,20 @@
import static java.util.stream.Collectors.toMap;
final class StandbyTaskAssignmentUtils {
- private StandbyTaskAssignmentUtils() {}
+ private StandbyTaskAssignmentUtils() {
+ }
Review comment:
nit: `{}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
