Gerrrr commented on a change in pull request #11945:
URL: https://github.com/apache/kafka/pull/11945#discussion_r835135226
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapper.java
##########
@@ -23,12 +23,13 @@
public class SubscriptionWrapper<K> {
- static final byte CURRENT_VERSION = 0;
+ static final byte CURRENT_VERSION = 1;
private final long[] hash;
private final Instruction instruction;
private final byte version;
private final K primaryKey;
+ private final Integer primaryPartition;
Review comment:
Added in fcfe805cd1847cb9f441535a30c6a8b87c27e8e1
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerde.java
##########
@@ -79,16 +79,27 @@ public void setIfUnset(final SerdeGetter getter) {
);
final ByteBuffer buf;
+ int dataLength = 2 + primaryKeySerializedData.length;
Review comment:
Done in a59a4f6fe2a0d61d15656742f1d42862918f80a6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
