Gerrrr commented on a change in pull request #11945:
URL: https://github.com/apache/kafka/pull/11945#discussion_r835404011
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java
##########
@@ -64,7 +64,7 @@ public void setIfUnset(final SerdeGetter getter) {
@Override
public byte[] serialize(final String topic, final
SubscriptionResponseWrapper<V> data) {
-
//{1-bit-isHashNull}{7-bits-version}{Optional-16-byte-Hash}{n-bytes serialized
data}
+
//{1-bit-isHashNull}{7-bits-version}{4-bytes-primaryPartition}{Optional-16-byte-Hash}{n-bytes
serialized data}
Review comment:
What will happen when an old processor receives a v1 record and throws
an exception? Will it throw that record on the floor or just block the
processing until the upgrade?
As John suggested in
[KAFKA-10336](https://issues.apache.org/jira/browse/KAFKA-10336), we can pass
`UPGRADE_FROM` into the serde so that it produces v0 records if the option is
set. I will also add `3.3` as a valid choice for that option. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
