Gerrrr commented on a change in pull request #11945:
URL: https://github.com/apache/kafka/pull/11945#discussion_r836421028
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java
##########
@@ -64,7 +64,7 @@ public void setIfUnset(final SerdeGetter getter) {
@Override
public byte[] serialize(final String topic, final
SubscriptionResponseWrapper<V> data) {
-
//{1-bit-isHashNull}{7-bits-version}{Optional-16-byte-Hash}{n-bytes serialized
data}
+
//{1-bit-isHashNull}{7-bits-version}{4-bytes-primaryPartition}{Optional-16-byte-Hash}{n-bytes
serialized data}
Review comment:
Added `UPGRADE_FROM` in
[d9f6c52](https://github.com/apache/kafka/pull/11945/commits/d9f6c52e2fa3a7ebd46efdade63a0c392acc8d0c).
There, I added all versions from 2.7 to 3.2 as `UPGRADE_FROM` options. If
serde detects the upgrade, it uses v0 format to serialize the data.
Deserializer does not need any changes as there is no difference between v0 and
upgrade-from-v0 formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
