cmccabe commented on code in PR #12036:
URL: https://github.com/apache/kafka/pull/12036#discussion_r848902316


##########
metadata/src/main/java/org/apache/kafka/controller/ProducerIdControlManager.java:
##########
@@ -34,10 +35,15 @@ public class ProducerIdControlManager {
 
     private final ClusterControlManager clusterControlManager;
     private final TimelineLong nextProducerId; // Initializes to 0
+    private final TimelineInteger brokerId;

Review Comment:
   Since these are all changed at the same time, it would be better to have a 
`TimelineObject<LatestProducerIdBlock>`. Then you could just have a a `long, 
int, long` or whatever.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to