cmccabe commented on code in PR #12036:
URL: https://github.com/apache/kafka/pull/12036#discussion_r848905064
##########
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##########
@@ -25,109 +25,138 @@
import java.util.Map.Entry;
import java.util.Map;
import java.util.NoSuchElementException;
-import java.util.Set;
import java.util.TreeMap;
import org.apache.kafka.common.metadata.FeatureLevelRecord;
import org.apache.kafka.common.protocol.Errors;
import org.apache.kafka.common.requests.ApiError;
+import org.apache.kafka.common.utils.LogContext;
+import org.apache.kafka.metadata.FinalizedControllerFeatures;
import org.apache.kafka.server.common.ApiMessageAndVersion;
-import org.apache.kafka.metadata.FeatureMap;
-import org.apache.kafka.metadata.FeatureMapAndEpoch;
import org.apache.kafka.metadata.VersionRange;
import org.apache.kafka.timeline.SnapshotRegistry;
import org.apache.kafka.timeline.TimelineHashMap;
+import org.slf4j.Logger;
import static
org.apache.kafka.common.metadata.MetadataRecordType.FEATURE_LEVEL_RECORD;
public class FeatureControlManager {
+ public enum DowngradeType {
Review Comment:
Do we have to duplicate this here? Seems like using the admin enum would be
perfectly adequate and less boilerplate.
Of course we have to check for unknown values, but that's true even if we
use a wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
