mumrah commented on code in PR #12036:
URL: https://github.com/apache/kafka/pull/12036#discussion_r849653835


##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -37,8 +37,8 @@ import 
org.apache.kafka.common.security.scram.internals.ScramMechanism
 import 
org.apache.kafka.common.security.token.delegation.internals.DelegationTokenCache
 import org.apache.kafka.common.utils.{LogContext, Time}
 import org.apache.kafka.common.{ClusterResource, Endpoint}
-import org.apache.kafka.controller.{Controller, QuorumController, 
QuorumControllerMetrics}
-import org.apache.kafka.metadata.{KafkaConfigSchema, VersionRange}
+import org.apache.kafka.controller.{Controller, QuorumController, 
QuorumControllerMetrics, QuorumFeatures}

Review Comment:
   Could you clarify what you mean by "missing"?
   
   FinalizedControllerFeatures is the return type we use in Controller for the 
`finalizedFeatures()` call.
   
   QuorumFeatures is used in this class down on line 163
   
   ```
         val quorumFeatures = QuorumFeatures.create(config.nodeId, 
QuorumFeatures.defaultFeatureMap())
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to