[GitHub] [kafka] dengziming commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

[GitBox]

dengziming commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r865512959


##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends 
KafkaServerTestHarness with Logging wi
       killBroker(0)
       val aliveServers = brokers.filterNot(_.config.brokerId == 0)
       TestUtils.waitForPartitionMetadata(aliveServers, underMinIsrTopic, 0)
-      val output = TestUtils.grabConsoleOutput(
-        topicService.describeTopic(new 
TopicCommandOptions(Array("--under-min-isr-partitions"))))
+      var output = ""
+      TestUtils.waitUntilTrue(
+        () => {
+          output = TestUtils.grabConsoleOutput(
+            topicService.describeTopic(new 
TopicCommandOptions(Array("--under-min-isr-partitions"))))

Review Comment:
   Sorry, it seems we won't remove a broker from isr if it's the only replica 
so this change doesn't make sense, to make it work as expected we should change 
it like this:
   ```
   xxxx && broker.metadataCache.getPartitionInfo(offlineTopic, 0).get.leader() 
== MetadataResponse.NO_LEADER_ID
   ```
   
   You can make further investigation about why the isr of 
TopicPartition(offlineTopic, 0) still contains broker 0 after broker 0 is 
killed if you are interested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org