dengziming commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r870248221
##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -732,7 +733,18 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHarness with Logging wi
try {
killBroker(0)
val aliveServers = brokers.filterNot(_.config.brokerId == 0)
- TestUtils.waitForPartitionMetadata(aliveServers, underMinIsrTopic, 0)
+
+ if (isKRaftTest()) {
+ TestUtils.ensureConsistentKRaftMetadata(aliveServers,
controllerServer, "Timeout waiting for topic configs propagating to brokers")
+ } else {
+ TestUtils.waitUntilTrue(
Review Comment:
Since this test only fails for KRaft mode and zk will be deprecated in 3.4.0
and totally removed in 4.0.0 I'm inclined to leave it as it was, but it's also
OK to improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
