cmccabe commented on code in PR #12183:
URL: https://github.com/apache/kafka/pull/12183#discussion_r882186601
##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -175,6 +174,11 @@ class ControllerServer(
OptionalLong.empty()
}
+ val maxIdleIntervalNs = config.metadataMaxIdleIntervalMs match {
Review Comment:
It's more traditional to have conversion stuff like this in KafkaConfig. If
you had a function like `maxIdleIntervalNs` there, it could return Option[Long]
and we could convert that into OptionalLong as needed (I think a simple asScala
can do it if you have the optional converter imported...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
