cmccabe commented on code in PR #12183:
URL: https://github.com/apache/kafka/pull/12183#discussion_r882192056
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -302,12 +302,30 @@ public QuorumController build() throws Exception {
KafkaEventQueue queue = null;
try {
queue = new KafkaEventQueue(time, logContext, threadNamePrefix
+ "QuorumController");
- return new QuorumController(logContext, nodeId, clusterId,
queue, time,
- configSchema, raftClient, quorumFeatures,
defaultReplicationFactor,
- defaultNumPartitions, isLeaderRecoverySupported,
replicaPlacer, snapshotMaxNewRecordBytes,
- leaderImbalanceCheckIntervalNs, sessionTimeoutNs,
controllerMetrics,
- createTopicPolicy, alterConfigPolicy,
configurationValidator, authorizer,
- staticConfig, bootstrapMetadata);
+ return new QuorumController(
Review Comment:
sigh. all right, fine. I guess we might as well do one line per parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
