cmccabe commented on code in PR #12183:
URL: https://github.com/apache/kafka/pull/12183#discussion_r882191795
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -155,10 +156,10 @@ static public class Builder {
private QuorumFeatures quorumFeatures = null;
private short defaultReplicationFactor = 3;
private int defaultNumPartitions = 1;
- private boolean isLeaderRecoverySupported = false;
private ReplicaPlacer replicaPlacer = new StripedReplicaPlacer(new
Random());
private long snapshotMaxNewRecordBytes = Long.MAX_VALUE;
private OptionalLong leaderImbalanceCheckIntervalNs =
OptionalLong.empty();
+ private OptionalLong maxIdleIntervalNs = OptionalLong.empty();
Review Comment:
It's an interesting choice to have this off by default. I guess it probably
would complicate a bunch of junit tests since it would create records we're not
expecting. So maybe this is the correct way to go for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
