I'm not reversing the separation of GUI and test elements. What I am doing is to hold the test elements in the tree instead of GUI components. Cut/copy/paste is easier to implement this way because I just move around a serialized tree of test elements. I already have this tree of test elements and it is not necessary to traverse a tree of GUIs, create a test element for each GUI to get the tree of test elements to place in the clipboard. When the tree is pasted somewhere I would have to do the reverse: traverse the tree of test elements and create GUIs for each of them to add to the tree.
I don't like that idea and I can see no advantage of holding GUIs in the tree. From my point of view this just increases the memory footprint of JMeter. For my solution I hold the tree of test elements and I need only one single instance of each GUI component, and as they are created on demand, I need only one single instance of each GUI component used in the actual JMeter session. This is an incredible reduction in the memory footprint of JMeter and for me is worth the time I have to invest to do that refactoring.
So the question is: are you willing to accept these changes, at least to take into consideration to accept these changes? If not, there is no reason for Jordi to wait with source file reorganization.
Oliver
Mike Stover wrote:
Although I would like to see cut/copy/paste working, I don't agree with this approach. The GUI and testelements were separated for a reason, and I would not like to see that effort reversed. I don't see why cut/copy/paste is any more difficult with panels. If nothing else, you can easily call "createTestElement" from the currently existing panel and create a new one from scratch from that test element (as is done when loading .jmx files) to end up with a copy. This requires no revamping of the tree.
-Mike
On 30 Dec 2002 at 13:10, Oliver Rossmueller wrote:
Jordi,
I would be very happy if could postpone this operation. I'm implementing cut/copy/paste operations for the test plan tree. Unfortunatelly this requires a complete refactoring of the tree and element gui handling. Up to now the tree was holding gui panels, but it is hard to do cut/copy/paste with guis, therefore the tree is now holding the test elements itself. Now I have to change all the guis to immediately propagate changes to the test elements.
It is not possible to do this kind of changes without version control. Therefore I imported the JMeter HEAD branch into my cvs repository two weeks ago and am now working on a branch. This way it is possible for me to keep the HEAD up to date from the Jakarta repository and to merge my changes with the changes on the HEAD branch as soon as I've finished my changes (hopefully there will be not too much conflicts).
When you start now to move files around in the repository it gets even harder for me to keep my copy of the HEAD branch up to date and to merge my changes.So, PLEASE, don't do it now but in two weeks or so. THANKX.
Oliver
Jordi Salvat i Alabart wrote:
I've put into CVS the changes necessary to make the different components (jorphan, core, components, ...) be reasonably independent as we discussed a few weeks ago. Unfortunately this implied removing the functionality to load legacy test plans. I've added a note to the manuals to this respect -- I don't think it will be a real problem for anyone.
The next steps are to shuffle a few components around and to change the build.xml file to take advantage of this independency. The component-shuffling is a sensible operation, since it may break some patches out there. You may get messages in the lines of:
�
can't find file to patch at input line 449
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -Naur src/core/org/apache/jmeter/control/LoopController.java srcXX/core/org/apache/jmeter/control/LoopController.java
|--- src/core/org/apache/jmeter/control/LoopController.java 2002-08-11 21:24:40.000000000 +0200
|+++ srcXX/core/org/apache/jmeter/control/LoopController.java 2002-12-15 02:21:48.000000000 +0100
--------------------------
File to patch:
�
If this happens, just look for the file in some other component -- it may have been moved around.
Salut,
Jordi.
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
-- Oliver Rossmueller Software Engineer Hamburg, Germany mailto:[EMAIL PROTECTED]-- Michael Stover [EMAIL PROTECTED] Yahoo IM: mstover_ya ICQ: 152975688 AIM: mstover777 -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
-- Oliver Rossmueller Software Engineer Hamburg, Germany mailto:[EMAIL PROTECTED]
smime.p7s
Description: S/MIME Cryptographic Signature
