I would only question the moving of RecordController. I don't think the notion of recording actions is limited to HTTP, though that's the only protocol that currently implements it. I don't see a problem with the protocol-specific code being dependent on the component section.
-Mike On 30 Dec 2002 at 17:05, Jordi Salvat i Alabart wrote: > Uh Oh! I'm really sorry -- it's already done. I should have waited a bit > more... > > Yes, I know it gets hard -- and that was the reason for my posting. > > We have two solutions: I undo the changes (a lot of work for me) or you > live with it (a lot of work for you). You'll see however that with these > changes in place the rebuild process is SOOO much faster... it may pay > off the extra work. > > FYI, this is the list of components moved around (it's not many): > > From components to core -- because they're used in the Test Plan component: > org/apache/jmeter/config/Argument.java > org/apache/jmeter/config/Arguments.java > org/apache/jmeter/config/gui/ArgumentsPanel.java > > From components to core -- because they're used both by JDBC and FTP: > org/apache/jmeter/config/gui/LoginConfigGui.java > org/apache/jmeter/config/LoginConfig.java > > From components to core -- because it is very core :-) > org/apache/jmeter/control/GenericController.java > org/apache/jmeter/control/gui/LogicControllerGui.java > > From components to core -- because it's used by the ThreadGroup: > org/apache/jmeter/control/gui/LoopControlPanel.java > org/apache/jmeter/control/LoopController.java > > From components to protocol/http -- because that's where it belongs: > org/apache/jmeter/control/gui/RecordController.java > > From core to components -- because that's where it belongs: > org/apache/jmeter/visualizers/AccumListener.java > org/apache/jmeter/visualizers/GraphAccumListener.java > org/apache/jmeter/visualizers/GraphListener.java > > Removed (from core) -- because it's now deprecated: > org/apache/jmeter/save/old/** > > I leave it to you to decide: please tell me if you want me to undo my > changes. > > Salut, > > Jordi. > > Oliver Rossmueller wrote: > > Jordi, > > > > I would be very happy if could postpone this operation. I'm implementing > > cut/copy/paste operations for the test plan tree. Unfortunatelly this > > requires a complete refactoring of the tree and element gui handling. Up > > to now the tree was holding gui panels, but it is hard to do > > cut/copy/paste with guis, therefore the tree is now holding the test > > elements itself. Now I have to change all the guis to immediately > > propagate changes to the test elements. > > > > It is not possible to do this kind of changes without version control. > > Therefore I imported the JMeter HEAD branch into my cvs repository two > > weeks ago and am now working on a branch. This way it is possible for me > > to keep the HEAD up to date from the Jakarta repository and to merge my > > changes with the changes on the HEAD branch as soon as I've finished my > > changes (hopefully there will be not too much conflicts). > > > > When you start now to move files around in the repository it gets even > > harder for me to keep my copy of the HEAD branch up to date and to merge > > my changes.So, PLEASE, don't do it now but in two weeks or so. THANKX. > > > > Oliver > > > > > > Jordi Salvat i Alabart wrote: > > > >> I've put into CVS the changes necessary to make the different > >> components (jorphan, core, components, ...) be reasonably independent > >> as we discussed a few weeks ago. Unfortunately this implied removing > >> the functionality to load legacy test plans. I've added a note to the > >> manuals to this respect -- I don't think it will be a real problem for > >> anyone. > >> > >> The next steps are to shuffle a few components around and to change > >> the build.xml file to take advantage of this independency. The > >> component-shuffling is a sensible operation, since it may break some > >> patches out there. You may get messages in the lines of: > >> > >> � > >> can't find file to patch at input line 449 > >> Perhaps you used the wrong -p or --strip option? > >> The text leading up to this was: > >> -------------------------- > >> |diff -Naur src/core/org/apache/jmeter/control/LoopController.java > >> srcXX/core/org/apache/jmeter/control/LoopController.java > >> |--- src/core/org/apache/jmeter/control/LoopController.java > >> 2002-08-11 21:24:40.000000000 +0200 > >> |+++ srcXX/core/org/apache/jmeter/control/LoopController.java > >> 2002-12-15 02:21:48.000000000 +0100 > >> -------------------------- > >> File to patch: > >> � > >> > >> If this happens, just look for the file in some other component -- it > >> may have been moved around. > >> > >> Salut, > >> > >> Jordi. > >> > >> > >> > >> > >> -- > >> To unsubscribe, e-mail: > >> <mailto:[EMAIL PROTECTED]> > >> For additional commands, e-mail: > >> <mailto:[EMAIL PROTECTED]> > >> > >> > > > > > > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > -- Michael Stover [EMAIL PROTECTED] Yahoo IM: mstover_ya ICQ: 152975688 AIM: mstover777 -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
