Egon,

I took a look at Convertor.java

>> 2. move the cdk/libio/jmol/Convertor.java to Jmol's CVS, so that CDK
>> less
>>     depends on jmol.jar to get compiled
This looks like a very good idea to me.

As far as I can tell, the only references from cdk to jmol are in:
 applications/PublicJmol.java
 applications/Viewer.java
 libio/jmol/Convertor.java
 test/libio/JmolLibIOTest.java

It seems to me that there should not be any dependancies from the cdk core
to jmol. So we should put the appropriate parts into Jmol.

If there are pieces which you feel do not belong in Jmol (the
applications?), then I recommend that they be pulled out of the core cdk
and put into a separate cdkapps project. That way the core cdk library
would not have dependencies on an application.


>> 3. update the new Convertor.java to match the current Jmol data
>> classes 4. Use the new Convertor.java to read ShelX
>>
> Hmmm ... I am not familiar with Convertor.java. I will take a look at it
> too.
Now that an org.openscience.jmol.Atom *is* an org.openscience.cdk.Atom,
what is the primary purpose of the Convertor? Is it only for the
application/Viewer?

Since you want to get rid of jmol.Atom, what needs to be done to complete
the switch?

Miguel





-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Jmol-developers mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jmol-developers

Reply via email to