> Right, I've copied the Convertor to Jmol's CVS, so that it can be > removed from CDK. In the future it would be obsolete all together... yes
> The PublicJmol.java in CDK can be removed too, because I can make > the Jmol's, Jmol.java public... (PublicJmol.java is just a sort of > wrapper). I am not familiar with this > The Viewer.java I need to modify so that it does not build depend on > Jmol, just run depend on it, by using dynamic class loading. sounds like a good idea > Well, the CDK core must not depend on anything at all, except for a java > compiler and runtime... good > >> If there are pieces which you feel do not belong in Jmol (the >> applications?), then I recommend that they be pulled out of the core >> cdk and put into a separate cdkapps project. That way the core cdk >> library would not have dependencies on an application. >> >> >> 3. update the new Convertor.java to match the current Jmol data >> classes 4. Use the new Convertor.java to read ShelX >> > >> > Hmmm ... I am not familiar with Convertor.java. I will take a look >> at it too. >> >> Now that an org.openscience.jmol.Atom *is* an >> org.openscience.cdk.Atom, what is the primary purpose of the >> Convertor? Is it only for the application/Viewer? > > At this moment it is mostly for casting CDK Atom into Jmol Atom (see > Convertor in Jmol) and for converting CDK's Crystal into Jmol crystal. > Fabian does not use Jmol's atom class, I think. ok >> Since you want to get rid of jmol.Atom, what needs to be done to >> complete the switch? > > Removal of AtomType.java (which you did yesterday), BaseAtomType, removing BaseAtomType.java did not seem too easy to me because I have never really looked at that code. if I work up the courage I may try to get rid of it. > and > more difficult (we need to discuss this with Fabian) the removal of > Crystal.java.... -------------------------------------------------- Miguel Howard [EMAIL PROTECTED] c/Pe�a Primera 11-13 esc dcha 6B 37002 Salamanca Espa�a Spain -------------------------------------------------- telefono casa 923 27 10 82 movil 650 52 54 58 -------------------------------------------------- To call from the US dial 9:00 am Pacific US = home 011 34 923 27 10 82 12:00 noon Eastern US = cell 011 34 650 52 54 58 6:00 pm Spain -------------------------------------------------- ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Jmol-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jmol-developers
