>That's fine, but then Emacs edits those all away, I think. Anyway, I >don't plan on using CTRL-SHIFT-F. I'm learning fast, I think, what the >desired coding conventions are here, but it's open source, it's had >how many contributors? It's not perfectly formatted to start with. I >can show you 215 places in the code where "!" is not followed by a >blank and 213 places where it is. Is it worth it to go through and >change all those?
I don't think. Just one comment: if you want to reformat badly formatted code, do a separate commit for it. Don't do a commit consisting of reformatting and modifications, because later debugging could then be more difficult. When a bug shows up, it's sometimes useful to see the differences between revisions of a file. >> There are other examples, it's just my opinion that following rules >> won't be as good as human judgement. >> > >OK, this is just style. You are suggesting a personal style. I'm not >sure Miguel is up for that. I'm comfortable if it generally looks neat >and I can follow the indents. Most of what you have there is very >subtle -- groupings that "make sense" for example, maybe to you.... I am not suggesting a personal style, I just don't believe in entirely strict rules. Many developers group things in a class. Take the Viewer class for example, methods delegated to transform manager are grouped together, then methods delegated to color manager, ... When I am coding a big class, I always tend to group things that are closely related, it's easier to structure my thinking. The grouping is personal, but makes sense even if an other developer would have grouped it in an other that would also have made sense. >Miguel is going to use Emacs. I'm happy with trying my hardest to get >it right, as long as Miguel is happy periodically having to clean it >up. Obviously we don't want Emacs/Eclipse going back and forth >"fixing" the code. Yes, we don't want this, that's why I think entirely reformatting a class is not good in general. We can try to configure Eclipse to format more accordingly to what Miguel prefers, but even if we get something very very close, I still don't think reformatting an existing class being a good idea. BTW, in an other when I said "I am against this" doesn't mean that the final decision have to follow my own opinion. My English is far from perfect, so for me "I am against this" means that I strongly think it's not a good idea. Nico ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 _______________________________________________ Jmol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jmol-developers
