I have two comments about this patch. First it seems to me that shift clicking on events to select a whole bunch of them, like you would so in a list of a treeview isn't very necessary. Certainly it could be useful for deleting all the events on an instrument, but I think this is an edge case.
Secondly, how would users without a middle mouse button start a new selection? This patch would require a middle mouse button because selections are a very important feature in Jokosher. I know a lot of people who do not have a middle mouse button on their laptops, but maybe there is still a way because Linux on Mac users manage to get away without having a right mouse button. Otherwise I have no problems committing this patch. You have done a good job. Thanks, Laszlo On 27/03/2008, Daniel Holt <[EMAIL PROTECTED]> wrote: > Here are three patches that together make the following improvements to the > user interface: > > When starting a new selection within an event, any previous selection now > clears correctly > MMB now starts a selection within an event > Shift+MMB adds to a selection within an event or moves the selection within > an event: > If done on or before the beginning of the existing selection, stretches the > selection from the left > If done on or after the end of the existing selection, stretches the > selection from the right > If done amid the selection, drags the whole selection > Currently the drag starts with the end of the selection where the mouse > clicks, but the drag should start with the selection exactly where it is > > Ctrl+{L|R}MB now deselects an event if it's already selected > Shift+{L|R}MB now selects all events from the most recently selected event > to the currently clicked event. Can be combined with Ctrl+LMB Patches are > included as attachments, and affect Event.py, EventViewer.py, and > Instrument.py > > Daniel > > _______________________________________________ > jokosher-devel-list mailing list > jokosher-devel-list@gnome.org > http://mail.gnome.org/mailman/listinfo/jokosher-devel-list > > > _______________________________________________ jokosher-devel-list mailing list jokosher-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/jokosher-devel-list