I see where you're going and I quite like it, but I think passing an
argument to $.fn.text may not be the answer. As you suggested, it would be
counter intuitive for $.fn.text to return anything other than a string.
I'd probably favour creating a new method such as $.fn.textNode.
But then we're going into something that should not be included in the
jQuery core - it's functionality over-kill...
2008/9/30 Balazs Endresz <[EMAIL PROTECTED]>
>
> Someone came up with this recently:
>
> "Now, of course I can do this:
>
> $("#sandbox").text( $("a").text() );
>
> But I'd prefer to do this:
>
> $("a").text().appendTo("#sanbox"); "
>
>
> http://groups.google.com/group/jquery-en/browse_thread/thread/bbd886b73e7768e1
>
> I also think that this way would be a bit easier:
>
> $.fn._text = $.fn.text;
> $.fn.text = function( toTextNode ) {
> if( toTextNode === true )
> return
> this.pushStack( [ document.createTextNode( this._text() ) ] );
> return this._text( toTextNode );
> }
>
> And you could make it work by setting the first argument to true:
>
> $("a").text( true ).appendTo("#sanbox");
>
> Unfortunately that would also need a new method to replace the content
> like .text()
>
> Altogether it looks nice for me, though I'm not sure how intuitive is
> this?
>
> On Sep 26, 7:59 pm, "John Resig" <[EMAIL PROTECTED]> wrote:
> > I'm curious: Are there any pieces of code that use jQuery, right now,
> > that you feel are unelegant or ugly? (Presumably ones that've already
> > been optimized to the best of their ability.)
> >
> > One area of improvement that I was thinking of was something along the
> lines of:
> >
> > // ugly
> > $("#foo").val( $("#bar").val() );
> >
> > // a bit better
> > $("#foo").val( $("#bar") );
> >
> > this would be an easy change, just make .attr() do something like:
> >
> > if ( arg.jquery )
> > val = arg.val() || arg.text() || "";
> >
> > Any other thoughts? I wonder if there are common cases that could be
> > improved with some simple code additions to core.
> >
> > --John
>
> >
>
--
Cheers,
Diego A.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"jQuery Development" group.
To post to this group, send email to jquery-dev@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/jquery-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
