[
https://issues.apache.org/jira/browse/JSPWIKI-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704627#action_12704627
]
Andrew Jaquith commented on JSPWIKI-528:
----------------------------------------
These are all good ideas. I haven't taken a look at the specific patches yet,
but I've already (separately) fixed some of them as part of my rewrite of
ReferenceManager (ongoing). In general, I favor using Lists over Collections
for exactly the reason Greg cites. Thanks for taking this on.
> Rationalise the use of Collections, particularly with regard to pages
> ---------------------------------------------------------------------
>
> Key: JSPWIKI-528
> URL: https://issues.apache.org/jira/browse/JSPWIKI-528
> Project: JSPWiki
> Issue Type: Improvement
> Reporter: Greg Kable
> Priority: Minor
> Fix For: 3.0
>
> Attachments: jspwiki-528-AttachmentHandler.patch,
> jspwiki-528-LinkCollector.patch, jspwiki-528-SearchProviders.patch
>
>
> Most of the APIs return Collection rather than a finer interface and in many
> cases these collections are repeatedly repacked and resorted unnecessarily. I
> will go through all APIs that return collections of pages and make them
> return a finer interface - probably List for unordered collections and
> SortedSet for ordered collections. This will make the use of these
> collections much clearer for further development and give us some opportunity
> for future optimisations.
> This is likely to be a very wide set of changes across lots of different
> classes so I'll submit separate patches for each class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
